lkml.org 
[lkml]   [2019]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH][next] xfs: remove redundant assignment to variable error
On Wed, Nov 06, 2019 at 03:52:48PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable error is being initialized with a value that is never read
> and is being re-assigned a couple of statements later on. The
> assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")

Er... is there a coverity id that goes with this?

Patch looks fine otherwise.

--D

> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index b3188ea49413..2302f67d1a18 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1362,7 +1362,7 @@ xfs_fc_fill_super(
> {
> struct xfs_mount *mp = sb->s_fs_info;
> struct inode *root;
> - int flags = 0, error = -ENOMEM;
> + int flags = 0, error;
>
> mp->m_super = sb;
>
> --
> 2.20.1
>

\
 
 \ /
  Last update: 2019-11-06 16:59    [W:0.045 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site