Messages in this thread | | | Date | Wed, 6 Nov 2019 03:55:12 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/2] tracing: Use seq_buf_hex_dump() to dump buffers |
| |
On Wed, 6 Nov 2019 07:27:40 +0100 Piotr Maziarz <piotrx.maziarz@linux.intel.com> wrote:
> Without this, buffers can be printed with __print_array macro that has > no formatting options and can be hard to read. The other way is to > mimic formatting capability with multiple calls of trace event with one > call per row which gives performance impact and different timestamp in > each row. > > Signed-off-by: Piotr Maziarz <piotrx.maziarz@linux.intel.com> > Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> > --- > include/linux/trace_events.h | 5 +++++ > include/linux/trace_seq.h | 4 ++++ > include/trace/trace_events.h | 6 ++++++ > kernel/trace/trace_output.c | 15 +++++++++++++++ > kernel/trace/trace_seq.c | 30 ++++++++++++++++++++++++++++++ > 5 files changed, 60 insertions(+) >
I'd like to see in the patch series (patch 3?) a use case of these added functionality. Or at least a link to what would be using it.
Thanks!
-- Steve
| |