Messages in this thread | | | From | Navid Emamdoost <> | Date | Tue, 5 Nov 2019 23:37:22 -0600 | Subject | Re: [PATCH] NFSv4: fix memory leak if nfs4_begin_drain_session fails |
| |
Would you please review this patch?
On Thu, Sep 19, 2019 at 7:22 PM Navid Emamdoost <navid.emamdoost@gmail.com> wrote: > > In nfs4_try_migration, if nfs4_begin_drain_session fails the allocated > memory should be released. > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> > --- > fs/nfs/nfs4state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c > index cad4e064b328..124649f12067 100644 > --- a/fs/nfs/nfs4state.c > +++ b/fs/nfs/nfs4state.c > @@ -2096,7 +2096,7 @@ static int nfs4_try_migration(struct nfs_server *server, const struct cred *cred > > status = nfs4_begin_drain_session(clp); > if (status != 0) > - return status; > + goto out; > > status = nfs4_replace_transport(server, locations); > if (status != 0) { > -- > 2.17.1 >
-- Navid.
| |