| Date | Tue, 5 Nov 2019 20:21:54 +0000 | From | Ionela Voinescu <> | Subject | Re: [Patch v5 2/6] sched/fair: Add infrastructure to store and update instantaneous thermal pressure |
| |
Hi Thara,
On Tuesday 05 Nov 2019 at 13:49:42 (-0500), Thara Gopinath wrote: [...] > +static void trigger_thermal_pressure_average(struct rq *rq) > +{ > +#ifdef CONFIG_SMP > + update_thermal_load_avg(rq_clock_task(rq), rq, > + per_cpu(thermal_pressure, cpu_of(rq))); > +#endif > +}
Why did you decide to keep trigger_thermal_pressure_average and not call update_thermal_load_avg directly?
For !CONFIG_SMP you already have an update_thermal_load_avg function that does nothing, in kernel/sched/pelt.h, so you don't need that ifdef.
Thanks, Ionela.
> + > /* > * All the scheduling class methods: > */ > -- > 2.1.4 >
|