Messages in this thread | | | Date | Tue, 5 Nov 2019 15:02:56 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH 00/12] staging: dpaa2-ethsw: add support for control interface traffic |
| |
On Tue, Nov 05, 2019 at 02:24:35PM +0100, Greg KH wrote: > On Tue, Nov 05, 2019 at 02:34:23PM +0200, Ioana Ciornei wrote: > > This patch set adds support for Rx/Tx capabilities on switch port interfaces. > > Also, control traffic is redirected through ACLs to the CPU in order to > > enable proper STP protocol handling.
> I thought I asked for no new features until this code gets out of > staging? Only then can you add new stuff. Please work to make that > happen first.
Hi Greg
This is in response to my review of the code in staging. The current code is missing a core feature for an Ethernet switch driver, being able to send/receive frames from the host. At the moment it can only control the hardware for how it switches Ethernet frames coming into/going out of external ports.
One of the core ideas behind how linux handles Ethernet switches is that they are just a bunch of network interfaces. And currently, these network interfaces cannot send/receive. We would never move an Ethernet driver out of staging which cannot send/receive, so i don't see why we should move an Ethernet switch driver out of staging which also cannot send/receive.
Maybe this patchset could be minimised. The STP handling is just nice to have, and could wait until the driver has moved into the main tree.
Andrew
| |