lkml.org 
[lkml]   [2019]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/5] bus: hisi_lpc: Clean some types
From
Date
On 04/11/2019 18:39, Joe Perches wrote:
> On Tue, 2019-11-05 at 01:22 +0800, John Garry wrote:
>> Sparse complains of these:
>> drivers/bus/hisi_lpc.c:82:38: warning: incorrect type in argument 1 (different address spaces)
>> drivers/bus/hisi_lpc.c:82:38: expected void const volatile [noderef] <asn:2>*addr
>> drivers/bus/hisi_lpc.c:82:38: got unsigned char *
>> drivers/bus/hisi_lpc.c:131:35: warning: incorrect type in argument 1 (different address spaces)
>> drivers/bus/hisi_lpc.c:131:35: expected unsigned char *mbase
>> drivers/bus/hisi_lpc.c:131:35: got void [noderef] <asn:2>*membase
>> drivers/bus/hisi_lpc.c:186:35: warning: incorrect type in argument 1 (different address spaces)
>> drivers/bus/hisi_lpc.c:186:35: expected unsigned char *mbase
>> drivers/bus/hisi_lpc.c:186:35: got void [noderef] <asn:2>*membase
>> drivers/bus/hisi_lpc.c:228:16: warning: cast to restricted __le32
>> drivers/bus/hisi_lpc.c:251:13: warning: incorrect type in assignment (different base types)
>> drivers/bus/hisi_lpc.c:251:13: expected unsigned int [unsigned] [usertype] val
>> drivers/bus/hisi_lpc.c:251:13: got restricted __le32 [usertype] <noident>
>>
>> Clean them up.
>
> OK, it might also be good to change the _in and _out functions
> to use void * and not unsigned char * for buf

Hi Joe,

In fact, using unsigned char * is the right thing to do, and really the
upper layer prob should not be passing void *. I'll look at this as a
follow up.

Cheers,
John

>
> ---
> drivers/bus/hisi_lpc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 20c9571..ec2bfb 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -100,7 +100,7 @@ static int wait_lpc_idle(unsigned char *mbase, unsigned int waitcnt)
> */
> static int hisi_lpc_target_in(struct hisi_lpc_dev *lpcdev,
> struct lpc_cycle_para *para, unsigned long addr,
> - unsigned char *buf, unsigned long opcnt)
> + void *buf, unsigned long opcnt)
> {
> unsigned int cmd_word;
> unsigned int waitcnt;
> @@ -153,7 +153,7 @@ static int hisi_lpc_target_in(struct hisi_lpc_dev *lpcdev,
> */
> static int hisi_lpc_target_out(struct hisi_lpc_dev *lpcdev,
> struct lpc_cycle_para *para, unsigned long addr,
> - const unsigned char *buf, unsigned long opcnt)
> + const void *buf, unsigned long opcnt)
> {
> unsigned int waitcnt;
> unsigned long flags;
>
>
> .
>

\
 
 \ /
  Last update: 2019-11-05 10:51    [W:0.074 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site