Messages in this thread | | | From | John Stultz <> | Date | Mon, 4 Nov 2019 11:36:12 -0800 | Subject | Re: [PATCH v14 2/5] dma-buf: heaps: Add heap helpers |
| |
On Mon, Nov 4, 2019 at 11:34 AM John Stultz <john.stultz@linaro.org> wrote: > > On Sun, Nov 3, 2019 at 8:13 AM <sspatil@google.com> wrote: > > On Fri, Nov 01, 2019 at 09:42:35PM +0000, John Stultz wrote: > > > Add generic helper dmabuf ops for dma heaps, so we can reduce > > > the amount of duplicative code for the exported dmabufs. > > > > > > This code is an evolution of the Android ION implementation, so > > > thanks to its original authors and maintainters: > > > Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! > > > > > > Cc: Laura Abbott <labbott@redhat.com> > > > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> > > > Cc: Sumit Semwal <sumit.semwal@linaro.org> > > > Cc: Liam Mark <lmark@codeaurora.org> > > > Cc: Pratik Patel <pratikp@codeaurora.org> > > > Cc: Brian Starkey <Brian.Starkey@arm.com> > > > Cc: Vincent Donnefort <Vincent.Donnefort@arm.com> > > > Cc: Sudipto Paul <Sudipto.Paul@arm.com> > > > Cc: Andrew F. Davis <afd@ti.com> > > > Cc: Christoph Hellwig <hch@infradead.org> > > > Cc: Chenbo Feng <fengc@google.com> > > > Cc: Alistair Strachan <astrachan@google.com> > > > Cc: Hridya Valsaraju <hridya@google.com> > > > Cc: Sandeep Patil <sspatil@google.com> > > > Cc: Hillf Danton <hdanton@sina.com> > > > Cc: Dave Airlie <airlied@gmail.com> > > > Cc: dri-devel@lists.freedesktop.org > > > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > > > Reviewed-by: Brian Starkey <brian.starkey@arm.com> > > > Acked-by: Laura Abbott <labbott@redhat.com> > > > Tested-by: Ayan Kumar Halder <ayan.halder@arm.com> > > > Signed-off-by: John Stultz <john.stultz@linaro.org> > > > > I have one question and a naming suggestin below (sorry). > > > > Acked-by: Sandeep Patil <sspatil@android.com> > > > > + > > > +static void dma_heap_buffer_vmap_put(struct heap_helper_buffer *buffer) > > > +{ > > > + if (!--buffer->vmap_cnt) { > > > > nit: just checking here cause I don't know the order in which vmap_get() and > > vmap_put() is expected to be called from dmabuf, the manual refcounting > > based map/unmap is ok? > > > > I know ion had this for a while and it worked fine over the years, but I > > don't know if anybody saw any issues with it.
Sorry, I hit send before replying to this bit. I'll double check on this.
thanks again for the review! -john
| |