Messages in this thread | | | Subject | Re: [PATCH v6] coccicheck: Support search for SmPL scripts within selected directory hierarchy | From | Markus Elfring <> | Date | Mon, 4 Nov 2019 16:40:31 +0100 |
| |
> *Allow defining the environment variable “COCCI” as a directory to > search SmPL scripts. > > *Start a corresponding file determination if it contains an acceptable > path. > > *Update coccinelle.rst documents for use coccicheck with a directory > selection
‣ Do you really insist to use an enumeration without alignment in your change description?
‣ Can the following third item be nicer?
* Adjust software documentation for using coccicheck with a selected directory.
> +++ b/Documentation/dev-tools/coccinelle.rst > @@ -100,8 +100,8 @@ Two other modes provide some common combinations of these modes. … > +Using Coccinelle with defalut value
Why did you repeat a typo?
How do you think about to use the section title “Using Coccinelle with the default configuration”?
… > +semantic patch. In that case, the variable must be initialized with > +the name of the semantic patch to apply.
I prefer an other wording.
…, it should be set to the file name of the semantic patch to apply.
… > +directory. In that case, the variable must be initialized with the name of
…, it should be set to the …
Will the presented case distinction need another adjustment for the document outline?
… > Controlling Which Files are Processed by Coccinelle …
Did you overlook another update candidate (which I tried to point out before)? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=a99d8080aaf358d5d23581244e5da23b35e340b9#n189 “… COCCI variable may additionally be used to only apply a single semantic patch as shown in the previous section. …”
Regards, Markus
| |