Messages in this thread | | | Date | Mon, 4 Nov 2019 15:04:22 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 0/2] extcon: axp288: Move to swnodes |
| |
On Mon, Nov 04, 2019 at 03:09:04PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Tue, Oct 08, 2019 at 03:59:23PM +0200, Hans de Goede wrote: > > Hi, > > > > On 08-10-2019 14:25, Heikki Krogerus wrote: > > > Hi Hans, > > > > > > Fixed the compiler warning in this version. No other changes. > > > > > > The original cover letter: > > > > > > That AXP288 extcon driver is the last that uses build-in connection > > > description. I'm replacing it with a code that finds the role mux > > > software node instead. > > > > > > I'm proposing also here a little helper > > > usb_role_switch_find_by_fwnode() that uses > > > class_find_device_by_fwnode() to find the role switches. > > > > Both patches look good to me and I can confirm that things still > > work as they should on a CHT device with an AXP288 PMIC, so for both: > > > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > Tested-by: Hans de Goede <hdegoede@redhat.com> > > These two patches in this series are basically about the usb role API, > so can you take them?
Sure, will do that, thanks.
greg k-h
| |