Messages in this thread | | | From | Alexander Shishkin <> | Subject | Re: [GIT PULL 1/7] intel_th: gth: Fix the window switching sequence | Date | Mon, 04 Nov 2019 08:54:14 +0200 |
| |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Mon, Nov 04, 2019 at 08:25:39AM +0200, Alexander Shishkin wrote: >> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: >> >> > On Mon, Oct 28, 2019 at 09:06:45AM +0200, Alexander Shishkin wrote: >> >> Commit 8116db57cf16 ("intel_th: Add switch triggering support") added >> >> a trigger assertion of the CTS, but forgot to de-assert it at the end >> >> of the sequence. This results in window switches randomly not happening. >> >> >> >> Fix that by de-asserting the trigger at the end of the window switch >> >> sequence. >> >> >> >> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> >> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> >> --- >> >> drivers/hwtracing/intel_th/gth.c | 3 +++ >> >> 1 file changed, 3 insertions(+) >> > >> > Shouldn't this have a Fixes: tag and a cc: stable@ in it? >> > >> > I can add it if you say it's ok to. >> >> Fixes: yes, but cc: stable shouldn't be required if this goes into 5.4, >> because the buggy commit is in 5.4-rc1. > > 8116db57cf16 ("intel_th: Add switch triggering support") was in the 5.2 > kernel release.
Ah true. Thank you for checking that. Can you then also add a CC: stable?
I'll be sure to check these things next time.
Thanks, -- Alex
| |