Messages in this thread | | | Subject | Re: [PATCH v3 08/11] dt-bindings: pinctrl: qcom-wcd934x: Add bindings for gpio | From | Srinivas Kandagatla <> | Date | Mon, 4 Nov 2019 09:35:34 +0000 |
| |
Thanks for reviewing this!
On 03/11/2019 23:19, Linus Walleij wrote: > On Tue, Oct 29, 2019 at 12:29 PM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > >> Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated >> gpio controller to control 5 gpios on the chip. This patch adds >> required device tree bindings for it. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> .../pinctrl/qcom,wcd934x-pinctrl.yaml | 52 +++++++++++++++++++ > > The bindings look OK, but remind me if I have asked before (sorry then) > does these GPIOs expose some pin control properties and that is why > the driver is placed under pin control rather than the GPIO namespace? > I don't remember you asking about this before :-),
This controller just has Output enable bits, No pin control properties.
As you suggested I can move this to drivers/gpio in next version.
Thanks, srini
| |