lkml.org 
[lkml]   [2019]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 126/149] nl80211: fix validation of mesh path nexthop
    Date
    From: Markus Theil <markus.theil@tu-ilmenau.de>

    commit 1fab1b89e2e8f01204a9c05a39fd0b6411a48593 upstream.

    Mesh path nexthop should be a ethernet address, but current validation
    checks against 4 byte integers.

    Cc: stable@vger.kernel.org
    Fixes: 2ec600d672e74 ("nl80211/cfg80211: support for mesh, sta dumping")
    Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
    Link: https://lore.kernel.org/r/20191029093003.10355-1-markus.theil@tu-ilmenau.de
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/wireless/nl80211.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/wireless/nl80211.c
    +++ b/net/wireless/nl80211.c
    @@ -284,7 +284,8 @@ static const struct nla_policy nl80211_p
    [NL80211_ATTR_MNTR_FLAGS] = { /* NLA_NESTED can't be empty */ },
    [NL80211_ATTR_MESH_ID] = { .type = NLA_BINARY,
    .len = IEEE80211_MAX_MESH_ID_LEN },
    - [NL80211_ATTR_MPATH_NEXT_HOP] = { .type = NLA_U32 },
    + [NL80211_ATTR_MPATH_NEXT_HOP] = { .type = NLA_BINARY,
    + .len = ETH_ALEN },

    [NL80211_ATTR_REG_ALPHA2] = { .type = NLA_STRING, .len = 2 },
    [NL80211_ATTR_REG_RULES] = { .type = NLA_NESTED },

    \
     
     \ /
      Last update: 2019-11-04 23:17    [W:4.049 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site