Messages in this thread | | | Date | Sun, 3 Nov 2019 10:26:04 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 1/4] soundwire: sdw_slave: add new fields to track probe status |
| |
On 23-10-19, 16:06, Pierre-Louis Bossart wrote: > Changes to the sdw_slave structure needed to solve race conditions on > driver probe.
Can you please explain the race you have observed, it would be a very useful to document it as well
> > The functionality is added in the next patch.
which one..?
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > include/linux/soundwire/sdw.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h > index 688b40e65c89..a381a596212b 100644 > --- a/include/linux/soundwire/sdw.h > +++ b/include/linux/soundwire/sdw.h > @@ -545,6 +545,10 @@ struct sdw_slave_ops { > * @node: node for bus list > * @port_ready: Port ready completion flag for each Slave port > * @dev_num: Device Number assigned by Bus > + * @probed: boolean tracking driver state > + * @probe_complete: completion utility to control potential races > + * on startup between driver probe/initialization and SoundWire > + * Slave state changes/imp-def interrupts > */ > struct sdw_slave { > struct sdw_slave_id id; > @@ -559,6 +563,8 @@ struct sdw_slave { > struct list_head node; > struct completion *port_ready; > u16 dev_num; > + bool probed; > + struct completion probe_complete; > }; > > #define dev_to_sdw_dev(_dev) container_of(_dev, struct sdw_slave, dev) > -- > 2.20.1
-- ~Vinod
| |