lkml.org 
[lkml]   [2019]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1] net: WireGuard secure network tunnel
On Fri, Nov 29, 2019 at 7:27 AM David Miller <davem@davemloft.net> wrote:
>
> From: "Jason A. Donenfeld" <Jason@zx2c4.com>
> Date: Fri, 29 Nov 2019 04:32:05 +0100
>
> > I'm not a huge fan of doing manual skb surgery either. The annoying
> > thing here is that skb_gso_segment returns a list of skbs that's
> > terminated by the last one's next pointer being NULL. I assume it's this
> > way so that the GSO code doesn't have to pass a head around.
>
> Sorry, I missed that this was processing a GSO list which doesn't use
> double linked list semantics.
>
> So ignore my feedback on this one :-)

Okay, no problem. I'll submit some global tree-wide cleanup patches in
the way of a helper macro sometime after all the wireguard dust
settles, then, and we can assess that separately.

\
 
 \ /
  Last update: 2019-11-29 12:48    [W:0.063 / U:19.476 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site