Messages in this thread | | | Subject | Re: [PATCH] mm/vmscan.c: remove unused return value of shrink_node | From | David Hildenbrand <> | Date | Thu, 28 Nov 2019 16:10:25 +0100 |
| |
On 28.11.19 15:35, Liu Song wrote: > From: Liu Song <liu.song11@zte.com.cn> > > The return value of shrink_node is not used, so remove > unnecessary operations. > > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > --- > mm/vmscan.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 44df66a98f2a..fd282d86f4ad 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2652,7 +2652,7 @@ static bool pgdat_memcg_congested(pg_data_t *pgdat, struct mem_cgroup *memcg) > (memcg && memcg_congested(pgdat, memcg)); > } > > -static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) > +static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) > { > struct reclaim_state *reclaim_state = current->reclaim_state; > unsigned long nr_reclaimed, nr_scanned; > @@ -2818,8 +2818,6 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) > */ > if (reclaimable) > pgdat->kswapd_failures = 0; > - > - return reclaimable; > } > > /* >
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |