lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 5/6] MIPS: X1000: Add pdma controller DT node.
From
Date
Hi Paul,

On 2019年11月28日 00:48, Paul Cercueil wrote:
> Hi Zhou,
>
>
> Le mer., nov. 27, 2019 at 01:06, Zhou Yanjie <zhouyanjie@zoho.com> a
> écrit :
>> Add the appropriate DT node to probe the pdma controller driver
>> using the devicetree.
>>
>> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com>
>> ---
>>
>> Notes:
>> v4:
>> New patch.
>>
>> arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi
>> b/arch/mips/boot/dts/ingenic/x1000.dtsi
>> index 9e55edd..edfa70d 100644
>> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
>> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
>> @@ -1,5 +1,6 @@
>> // SPDX-License-Identifier: GPL-2.0
>> #include <dt-bindings/clock/x1000-cgu.h>
>> +#include <dt-bindings/dma/x1000-dma.h>
>
> You're not using any macro from that include file, so there's no need
> to have it here.
>

Sure, I will fix this in v7.

Thanks and best regards!

> Cheers,
> -Paul
>
>
>>
>> / {
>> #address-cells = <1>;
>> @@ -173,4 +174,16 @@
>>
>> status = "disabled";
>> };
>> +
>> + pdma: dma-controller@13420000 {
>> + compatible = "ingenic,x1000-dma";
>> + reg = <0x13420000 0x400
>> + 0x13421000 0x40>;
>> + #dma-cells = <2>;
>> +
>> + interrupt-parent = <&intc>;
>> + interrupts = <10>;
>> +
>> + clocks = <&cgu X1000_CLK_PDMA>;
>> + };
>> };
>> --
>> 2.7.4
>>
>>
>
>



\
 
 \ /
  Last update: 2019-11-28 04:29    [W:0.150 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site