Messages in this thread | | | Date | Wed, 27 Nov 2019 18:36:40 -0500 | From | Daniel Jordan <> | Subject | Re: [PATCH] padata: Remove broken queue flushing |
| |
On Tue, Nov 19, 2019 at 01:17:31PM +0800, Herbert Xu wrote: > The function padata_flush_queues is fundamentally broken because > it cannot force padata users to complete the request that is > underway. IOW padata has to passively wait for the completion > of any outstanding work. > > As it stands flushing is used in two places. Its use in padata_stop > is simply unnecessary because nothing depends on the queues to > be flushed afterwards. > > The other use in padata_replace is more substantial as we depend > on it to free the old pd structure. This patch instead uses the > pd->refcnt to dynamically free the pd structure once all requests > are complete. > > Fixes: 2b73b07ab8a4 ("padata: Flush the padata queues actively") > Cc: <stable@vger.kernel.org> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
| |