lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 041/151] ALSA: i2c/cs8427: Fix int to char conversion
    Date
    From: Philipp Klocke <philipp97kl@gmail.com>

    [ Upstream commit eb7ebfa3c1989aa8e59d5e68ab3cddd7df1bfb27 ]

    Compiling with clang yields the following warning:

    sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int'
    to 'char' changes value from 160 to -96 [-Wconstant-conversion]
    data[0] = CS8427_REG_AUTOINC | CS8427_REG_CORU_DATABUF;
    ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~

    Because CS8427_REG_AUTOINC is defined as 128, it is too big for a
    char field.
    So change data from char to unsigned char, that it can hold the value.

    This patch does not change the generated code.

    Signed-off-by: Philipp Klocke <philipp97kl@gmail.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/i2c/cs8427.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c
    index 7e21621e492a4..7fd1b40008838 100644
    --- a/sound/i2c/cs8427.c
    +++ b/sound/i2c/cs8427.c
    @@ -118,7 +118,7 @@ static int snd_cs8427_send_corudata(struct snd_i2c_device *device,
    struct cs8427 *chip = device->private_data;
    char *hw_data = udata ?
    chip->playback.hw_udata : chip->playback.hw_status;
    - char data[32];
    + unsigned char data[32];
    int err, idx;

    if (!memcmp(hw_data, ndata, count))
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-27 22:42    [W:4.086 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site