lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 083/151] ntb: intel: fix return value for ndev_vec_mask()
    Date
    From: Dave Jiang <dave.jiang@intel.com>

    [ Upstream commit 7756e2b5d68c36e170a111dceea22f7365f83256 ]

    ndev_vec_mask() should be returning u64 mask value instead of int.
    Otherwise the mask value returned can be incorrect for larger
    vectors.

    Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers")

    Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    Tested-by: Lucas Van <lucas.van@intel.com>
    Signed-off-by: Jon Mason <jdmason@kudzu.us>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/ntb/hw/intel/ntb_hw_intel.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
    index 7310a261c858b..e175cbeba266f 100644
    --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
    +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
    @@ -330,7 +330,7 @@ static inline int ndev_db_clear_mask(struct intel_ntb_dev *ndev, u64 db_bits,
    return 0;
    }

    -static inline int ndev_vec_mask(struct intel_ntb_dev *ndev, int db_vector)
    +static inline u64 ndev_vec_mask(struct intel_ntb_dev *ndev, int db_vector)
    {
    u64 shift, mask;

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-27 22:40    [W:3.211 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site