lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 012/306] gpio: max77620: Fixup debounce delays
    Date
    From: Thierry Reding <treding@nvidia.com>

    commit b0391479ae04dfcbd208b9571c375064caad9a57 upstream.

    When converting milliseconds to microseconds in commit fffa6af94894
    ("gpio: max77620: Use correct unit for debounce times") some ~1 ms gaps
    were introduced between the various ranges supported by the controller.
    Fix this by changing the start of each range to the value immediately
    following the end of the previous range. This way a debounce time of,
    say 8250 us will translate into 16 ms instead of returning an -EINVAL
    error.

    Typically the debounce delay is only ever set through device tree and
    specified in milliseconds, so we can never really hit this issue because
    debounce times are always a multiple of 1000 us.

    The only notable exception for this is drivers/mmc/host/mmc-spi.c where
    the CD GPIO is requested, which passes a 1 us debounce time. According
    to a comment preceeding that code this should actually be 1 ms (i.e.
    1000 us).

    Reported-by: Pavel Machek <pavel@denx.de>
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    Acked-by: Pavel Machek <pavel@denx.de>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpio/gpio-max77620.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/gpio/gpio-max77620.c
    +++ b/drivers/gpio/gpio-max77620.c
    @@ -163,13 +163,13 @@ static int max77620_gpio_set_debounce(st
    case 0:
    val = MAX77620_CNFG_GPIO_DBNC_None;
    break;
    - case 1000 ... 8000:
    + case 1 ... 8000:
    val = MAX77620_CNFG_GPIO_DBNC_8ms;
    break;
    - case 9000 ... 16000:
    + case 8001 ... 16000:
    val = MAX77620_CNFG_GPIO_DBNC_16ms;
    break;
    - case 17000 ... 32000:
    + case 16001 ... 32000:
    val = MAX77620_CNFG_GPIO_DBNC_32ms;
    break;
    default:

    \
     
     \ /
      Last update: 2019-11-27 22:30    [W:4.067 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site