lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 218/306] wlcore: Fix the return value in case of error in wlcore_vendor_cmd_smart_config_start()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 3419348a97bcc256238101129d69b600ceb5cc70 ]

    We return 0 unconditionally at the end of
    'wlcore_vendor_cmd_smart_config_start()'.
    However, 'ret' is set to some error codes in several error handling paths
    and we already return some error codes at the beginning of the function.

    Return 'ret' instead to propagate the error code.

    Fixes: 80ff8063e87c ("wlcore: handle smart config vendor commands")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ti/wlcore/vendor_cmd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/ti/wlcore/vendor_cmd.c b/drivers/net/wireless/ti/wlcore/vendor_cmd.c
    index dbe78d8491eff..7f34ec077ee57 100644
    --- a/drivers/net/wireless/ti/wlcore/vendor_cmd.c
    +++ b/drivers/net/wireless/ti/wlcore/vendor_cmd.c
    @@ -70,7 +70,7 @@ wlcore_vendor_cmd_smart_config_start(struct wiphy *wiphy,
    out:
    mutex_unlock(&wl->mutex);

    - return 0;
    + return ret;
    }

    static int
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-27 22:24    [W:4.033 / U:1.644 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site