lkml.org 
[lkml]   [2019]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUGFIX PATCH v3 1/4] selftests/ftrace: Fix to check the existence of set_ftrace_filter
On Mon, 25 Nov 2019 20:54:29 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 26 Nov 2019 09:13:45 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > > > @@ -93,7 +96,6 @@ initialize_ftrace() { # Reset ftrace to initial-state
> > > > disable_events
> > > > [ -f set_event_pid ] && echo > set_event_pid
> > > > [ -f set_ftrace_pid ] && echo > set_ftrace_pid
> > > > - [ -f set_ftrace_filter ] && echo | tee set_ftrace_*
> > >
> > > The above should be changed to:
> > >
> > > [ -f set_ftrace_notrace ] && echo > set_ftrace_notrace
> >
> > Ah, good point! I think that should be done by another patch, since
> > it will improve ftracetest.
>
> No, it belongs in this patch, because you are removing:
>
> [ -f set_ftrace_filter ] && echo | tee set_ftrace_*
>
> which is equivalent to:
>
> [ -f set_ftrace_filter ] && echo > set_ftrace_filter
> [ -f set_ftrace_filter ] && echo > set_ftrace_notrace
>
> as the "tee set_ftrace_*" covers both.

Ah, I see.

>
> Without this change, this patch removes the update to
> set_ftrace_notrace.

OK, I'll update it.

Thank you!

>
> -- Steve


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2019-11-26 08:32    [W:0.053 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site