lkml.org 
[lkml]   [2019]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 11/11] sched/fair: rework find_idlest_group
From
Date
On 25/11/2019 09:59, Vincent Guittot wrote:
>>> + case group_imbalanced:
>>> + case group_asym_packing:
>>> + /* Those type are not used in the slow wakeup path */
>>> + return NULL;
>>
>> I suppose group_asym_packing could be handled similarly to misfit, right?
>> i.e. make the group type group_asym_packing if
>>
>> !sched_asym_prefer(sg.asym_prefer_cpu, local.asym_prefer_cpu)
>
> Unlike group_misfit_task that was somehow already taken into account
> through the comparison of spare capacity, group_asym_packing was not
> considered at all in find_idlest_group so I prefer to stay
> conservative and wait for users of asym_packing to come with a need
> before adding this new mechanism.
>

Right, makes sense.

\
 
 \ /
  Last update: 2019-11-25 12:13    [W:0.280 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site