Messages in this thread | | | Subject | Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node | From | "H. Nikolaus Schaller" <> | Date | Sun, 24 Nov 2019 18:59:07 +0100 |
| |
Hi Paul, Tony,
> Am 24.11.2019 um 18:48 schrieb Tony Lindgren <tony@atomide.com>: > > * Paul Cercueil <paul@crapouillou.net> [191124 12:58]: >> Le dim., nov. 24, 2019 at 12:40, H. Nikolaus Schaller <hns@goldelico.com> a >> écrit : >>> and add interrupt and clocks. > ... >>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi >>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi >>> @@ -46,6 +46,17 @@ >>> #clock-cells = <1>; >>> }; >>> >>> + gpu: gpu@13040000 { >> >> We try to keep the nodes ordered by address, could you move this node where >> it belongs? > ...
Yes, I have noted.
> >>> + compatible = "ingenic,jz4780-sgx540-120", "img,sgx540-120", >>> "img,sgx540", "img,sgx5"; >>> + reg = <0x13040000 0x4000>; >>> + >>> + clocks = <&cgu JZ4780_CLK_GPU>; >>> + clock-names = "gpu"; > > Just checking.. Is there something else to configure here > potentially in addition to the clocks?
It doesn't look so. Unfortuantely there isn't much information except a v3.18 kernel supported by the vendor and that one also just has a gpu node with clock control.
> That is, do we need to do some interconnect specific > configuration etc in addition to the clocks to have > runtime PM work for enabling and disabling sgx on > jz4780?
I think we have to leave that open for further study.
BR, Nikolaus
| |