Messages in this thread Patch in this message | | | From | Masahiro Yamada <> | Subject | [PATCH 07/16] scripts/kallsyms: replace prefix_underscores_count() with strspn() | Date | Sat, 23 Nov 2019 22:27:18 +0900 |
| |
You can do equivalent with strspn(). I do not see noticeable performance difference.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> ---
scripts/kallsyms.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index 7b00b4030be4..a007d901c3a5 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -653,16 +653,6 @@ static int may_be_linker_script_provide_symbol(const struct sym_entry *se) return 0; } -static int prefix_underscores_count(const char *str) -{ - const char *tail = str; - - while (*tail == '_') - tail++; - - return tail - str; -} - static int compare_symbols(const void *a, const void *b) { const struct sym_entry *sa; @@ -691,8 +681,8 @@ static int compare_symbols(const void *a, const void *b) return wa - wb; /* sort by the number of prefix underscores */ - wa = prefix_underscores_count(sym_name(sa)); - wb = prefix_underscores_count(sym_name(sb)); + wa = strspn(sym_name(sa), "_"); + wb = strspn(sym_name(sb), "_"); if (wa != wb) return wa - wb; -- 2.17.1
| |