lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 172/222] powerpc/pseries: Fix DTL buffer registration
    Date
    From: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>

    [ Upstream commit db787af1b8a6b4be428ee2ea7d409dafcaa4a43c ]

    When CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is not set, we register the DTL
    buffer for a cpu when the associated file under powerpc/dtl in debugfs
    is opened. When doing so, we need to set the size of the buffer being
    registered in the second u32 word of the buffer. This needs to be in big
    endian, but we are not doing the conversion resulting in the below error
    showing up in dmesg:

    dtl_start: DTL registration for cpu 0 (hw 0) failed with -4

    Fix this in the obvious manner.

    Fixes: 7c105b63bd98 ("powerpc: Add CONFIG_CPU_LITTLE_ENDIAN kernel config option.")
    Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/pseries/dtl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/powerpc/platforms/pseries/dtl.c b/arch/powerpc/platforms/pseries/dtl.c
    index 39049e4884fbd..37de83c5ef172 100644
    --- a/arch/powerpc/platforms/pseries/dtl.c
    +++ b/arch/powerpc/platforms/pseries/dtl.c
    @@ -150,7 +150,7 @@ static int dtl_start(struct dtl *dtl)

    /* Register our dtl buffer with the hypervisor. The HV expects the
    * buffer size to be passed in the second word of the buffer */
    - ((u32 *)dtl->buf)[1] = DISPATCH_LOG_BYTES;
    + ((u32 *)dtl->buf)[1] = cpu_to_be32(DISPATCH_LOG_BYTES);

    hwcpu = get_hard_smp_processor_id(dtl->cpu);
    addr = __pa(dtl->buf);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-22 11:49    [W:4.175 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site