lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/7] mm/lruvec: add irqsave flags into lruvec struct
On Sat, Nov 16, 2019 at 11:15:01AM +0800, Alex Shi wrote:
> We need a irqflags vaiable to save state when do irqsave action, declare
> it here would make code more clear/clean.

This patch is wrong on multiple levels. Adding a field without the
users is completely pointless. And as a general pattern we never
add the irqsave flags to sturctures. They are an intimate part of the
calling conventions, and storing them in a structure will lead to
subtile bugs.

\
 
 \ /
  Last update: 2019-11-22 07:47    [W:0.158 / U:17.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site