Messages in this thread | | | Date | Sat, 23 Nov 2019 04:07:54 +0000 | From | Changbin Du <> | Subject | Re: [PATCH v5 0/2] perf: add support for logging debug messages to file |
| |
On Tue, Oct 22, 2019 at 12:35:01AM +0900, Namhyung Kim wrote: > Hello, > > On Fri, Oct 18, 2019 at 9:28 AM Changbin Du <changbin.du@gmail.com> wrote: > > > > When in TUI mode, it is impossible to show all the debug messages to > > console. This make it hard to debug perf issues using debug messages. > > This patch adds support for logging debug messages to file to resolve > > this problem. > > I thought I implemented a debug message view in TUI mode by saving > all the messages in a linked list. But it seems not sent to the list and I > cannot find it now. :( > Sounds bad :)
> Anyway I understand your concerns and the changes look ok to me, so > > Acked-by: Namhyung Kim <namhyung@kernel.org> > Thanks for your review.
| |