Messages in this thread | | | Date | Sat, 23 Nov 2019 07:27:16 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: picoxcell: add missed tasklet_kill |
| |
On Fri, Nov 22, 2019 at 05:36:35PM +0100, Marc Gonzalez wrote: > > > However, the IRQ handler is registered through devm which makes it > > hard to kill the tasklet after unregistering it. We should probably > > convert it to a normal request_irq so we can control how it's > > unregistered. > > Or inversely, registering the tasklet_kill() through devm, so that it > is called *after* the ISR unregistration.
Good Point. Chuhong, could you please try this approach to see if it gives us better code?
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |