lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 01/13] autofs: fix a leak in autofs_expire_indirect()
    Date
    From: Al Viro <viro@zeniv.linux.org.uk>

    [ Upstream commit 03ad0d703df75c43f78bd72e16124b5b94a95188 ]

    if the second call of should_expire() in there ends up
    grabbing and returning a new reference to dentry, we need
    to drop it before continuing.

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/autofs4/expire.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c
    index 2e1f50e467f15..02f0d373adbf7 100644
    --- a/fs/autofs4/expire.c
    +++ b/fs/autofs4/expire.c
    @@ -469,9 +469,10 @@ struct dentry *autofs4_expire_indirect(struct super_block *sb,
    */
    flags &= ~AUTOFS_EXP_LEAVES;
    found = should_expire(expired, mnt, timeout, how);
    - if (!found || found != expired)
    - /* Something has changed, continue */
    + if (found != expired) { // something has changed, continue
    + dput(found);
    goto next;
    + }

    if (expired != dentry)
    dput(dentry);
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-22 20:53    [W:3.290 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site