Messages in this thread |  | | Date | Fri, 22 Nov 2019 16:20:25 +0000 | | From | Al Viro <> | | Subject | Re: [PATCH] debugfs: Fix !DEBUG_FS debugfs_create_automount |
| |
On Thu, Nov 21, 2019 at 07:20:21PM +0900, Kusanagi Kouichi wrote: > If DEBUG_FS=n, compile fails with the following error: > > kernel/trace/trace.c: In function 'tracing_init_dentry': > kernel/trace/trace.c:8658:9: error: passing argument 3 of 'debugfs_create_automount' from incompatible pointer type [-Werror=incompatible-pointer-types] > 8658 | trace_automount, NULL); > | ^~~~~~~~~~~~~~~ > | | > | struct vfsmount * (*)(struct dentry *, void *) > In file included from kernel/trace/trace.c:24: > ./include/linux/debugfs.h:206:25: note: expected 'struct vfsmount * (*)(void *)' but argument is of type 'struct vfsmount * (*)(struct dentry *, void *)' > 206 | struct vfsmount *(*f)(void *), > | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
ACK. I'd probably add something along the lines of "the stub for debugfs_create_automount() used in !DEBUG_FS configs is misdeclared - its callback argument (unused by the stub) has the wrong type. Get the stub in sync with the real debugfs_create_automount()." to commit message.
|  |