Messages in this thread | | | Subject | Re: [PATCH -next] staging: hp100: Fix build error without ETHERNET | From | Randy Dunlap <> | Date | Fri, 22 Nov 2019 08:09:17 -0800 |
| |
On 11/12/19 6:13 PM, YueHaibing wrote: > It should depends on ETHERNET, otherwise building fails: > > drivers/staging/hp/hp100.o: In function `hp100_pci_remove': > hp100.c:(.text+0x165): undefined reference to `unregister_netdev' > hp100.c:(.text+0x214): undefined reference to `free_netdev' > > Fixes: 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging") > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> --- > drivers/staging/hp/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/hp/Kconfig b/drivers/staging/hp/Kconfig > index fb395cf..f20ab21 100644 > --- a/drivers/staging/hp/Kconfig > +++ b/drivers/staging/hp/Kconfig > @@ -6,6 +6,7 @@ > config NET_VENDOR_HP > bool "HP devices" > default y > + depends on ETHERNET > depends on ISA || EISA || PCI > ---help--- > If you have a network (Ethernet) card belonging to this class, say Y. >
-- ~Randy
| |