Messages in this thread | | | From | Bjørn Mork <> | Subject | Re: [PATCH] Revert "platform/x86: wmi: Destroy on cleanup rather than unregister" | Date | Fri, 22 Nov 2019 13:09:56 +0100 |
| |
Bjørn Mork <bjorn@mork.no> writes:
> Maybe we should add a WARN_ON(!MAJOR(devt)) or similar to > device_destroy() to prevent similar future problems?
No, that's definitely not a good idea. We have examples like drivers/tty/vt/vt.c which (ab)use the devt with zero major and a unique minor to keep track of devices. So forget about any warning.
But the device_destroy's with a static MKDEV(0,0) should be removed.
Bjørn
| |