lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 025/159] net: lan78xx: Bail out if lan78xx_get_endpoints fails
    Date
    From: Stefan Wahren <stefan.wahren@i2se.com>

    [ Upstream commit fa8cd98c06407b5798b927cd7fd14d30f360ed02 ]

    We need to bail out if lan78xx_get_endpoints() fails, otherwise the
    result is overwritten.

    Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet")
    Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
    Reviewed-by: Raghuram Chary Jallipalli <raghuramchary.jallipalli@microchip.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/usb/lan78xx.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
    index 45a6a7cae4bfc..fc922f8122801 100644
    --- a/drivers/net/usb/lan78xx.c
    +++ b/drivers/net/usb/lan78xx.c
    @@ -2246,6 +2246,11 @@ static int lan78xx_bind(struct lan78xx_net *dev, struct usb_interface *intf)
    int i;

    ret = lan78xx_get_endpoints(dev, intf);
    + if (ret) {
    + netdev_warn(dev->net, "lan78xx_get_endpoints failed: %d\n",
    + ret);
    + return ret;
    + }

    dev->data[0] = (unsigned long)kzalloc(sizeof(*pdata), GFP_KERNEL);

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-22 12:28    [W:3.776 / U:26.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site