lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 088/127] atl1e: checking the status of atl1e_write_phy_reg
    Date
    From: Kangjie Lu <kjlu@umn.edu>

    [ Upstream commit ff07d48d7bc0974d4f96a85a4df14564fb09f1ef ]

    atl1e_write_phy_reg() could fail. The fix issues an error message when
    it fails.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
    index 4f7e195af0bc6..0d08039981b54 100644
    --- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
    +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
    @@ -472,7 +472,9 @@ static void atl1e_mdio_write(struct net_device *netdev, int phy_id,
    {
    struct atl1e_adapter *adapter = netdev_priv(netdev);

    - atl1e_write_phy_reg(&adapter->hw, reg_num & MDIO_REG_ADDR_MASK, val);
    + if (atl1e_write_phy_reg(&adapter->hw,
    + reg_num & MDIO_REG_ADDR_MASK, val))
    + netdev_err(netdev, "write phy register failed\n");
    }

    static int atl1e_mii_ioctl(struct net_device *netdev,
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-22 06:57    [W:4.180 / U:0.676 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site