lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 091/220] msm/gpu/a6xx: Force of_dma_configure to setup DMA for GMU
    Date
    From: Jordan Crouse <jcrouse@codeaurora.org>

    [ Upstream commit 32aa27e15c28d3898ed6f9b3c98f95f34a81eab2 ]

    The point of the 'force_dma' parameter for of_dma_configure
    is to force the device to be set up even if DMA capability is
    not described by the firmware which is exactly the use case
    we have for GMU - we need SMMU to get set up but we have no
    other dma capabilities since memory is managed by the GPU
    driver. Currently we pass false so of_dma_configure() fails
    and subsequently GMU and GPU probe does as well.

    Fixes: 4b565ca5a2c ("drm/msm: Add A6XX device support")
    Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
    Tested-by: Sibi Sankar <sibis@codeaurora.org>
    Signed-off-by: Rob Clark <robdclark@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
    index 9acb9dfaf57e6..9cde79a7335c8 100644
    --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
    +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
    @@ -1140,7 +1140,7 @@ int a6xx_gmu_probe(struct a6xx_gpu *a6xx_gpu, struct device_node *node)

    gmu->dev = &pdev->dev;

    - of_dma_configure(gmu->dev, node, false);
    + of_dma_configure(gmu->dev, node, true);

    /* Fow now, don't do anything fancy until we get our feet under us */
    gmu->idle_level = GMU_IDLE_STATE_ACTIVE;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-22 12:12    [W:4.115 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site