lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 180/220] lightnvm: pblk: fix incorrect min_write_pgs
    Date
    From: Matias Bjørling <mb@lightnvm.io>

    [ Upstream commit 8bbd45d02a118cbefdf4e1a6274bd965a6aa3c59 ]

    The calculation of pblk->min_write_pgs should only use the optimal
    write size attribute provided by the drive, it does not correlate to
    the memory page size of the system, which can be smaller or larger
    than the LBA size reported.

    Signed-off-by: Matias Bjørling <mb@lightnvm.io>
    Reviewed-by: Javier González <javier@cnexlabs.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/lightnvm/pblk-init.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
    index 537e98f2b24a2..145922589b0c6 100644
    --- a/drivers/lightnvm/pblk-init.c
    +++ b/drivers/lightnvm/pblk-init.c
    @@ -371,7 +371,7 @@ static int pblk_core_init(struct pblk *pblk)
    atomic64_set(&pblk->nr_flush, 0);
    pblk->nr_flush_rst = 0;

    - pblk->min_write_pgs = geo->ws_opt * (geo->csecs / PAGE_SIZE);
    + pblk->min_write_pgs = geo->ws_opt;
    max_write_ppas = pblk->min_write_pgs * geo->all_luns;
    pblk->max_write_pgs = min_t(int, max_write_ppas, NVM_MAX_VLBA);
    pblk_set_sec_per_write(pblk, pblk->min_write_pgs);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-22 12:09    [W:2.654 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site