lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 158/220] platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
    Date
    From: Nathan Chancellor <natechancellor@gmail.com>

    [ Upstream commit 8289c4b6f2e53750de78bd38cecb6bce4d7a988c ]

    Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
    emitted in the final assembly because it's only used in ARRAY_SIZE right
    now, which is a compile time evaluation since the array's size is known.

    drivers/platform/x86/mlx-platform.c:555:32: warning: variable
    'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
    [-Wunneeded-internal-declaration]
    static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
    ^
    1 warning generated.

    It appears this was a copy and paste mistake from when this item was
    first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
    Clang no longer warns.

    Link: https://github.com/ClangBuiltLinux/linux/issues/141
    Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new msn201x system type")
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Acked-by: Vadim Pasternak <vadimp@mellanox.com>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/x86/mlx-platform.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
    index 742a0c2179256..d17db140cb1fc 100644
    --- a/drivers/platform/x86/mlx-platform.c
    +++ b/drivers/platform/x86/mlx-platform.c
    @@ -575,7 +575,7 @@ static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {

    static
    struct mlxreg_core_hotplug_platform_data mlxplat_mlxcpld_msn201x_data = {
    - .items = mlxplat_mlxcpld_msn21xx_items,
    + .items = mlxplat_mlxcpld_msn201x_items,
    .counter = ARRAY_SIZE(mlxplat_mlxcpld_msn201x_items),
    .cell = MLXPLAT_CPLD_LPC_REG_AGGR_OFFSET,
    .mask = MLXPLAT_CPLD_AGGR_MASK_DEF,
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-22 12:04    [W:4.056 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site