lkml.org 
[lkml]   [2019]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 089/220] IB/mlx4: Avoid implicit enumerated type conversion
    Date
    From: Nathan Chancellor <natechancellor@gmail.com>

    [ Upstream commit b56511c15713ba6c7572e77a41f7ddba9c1053ec ]

    Clang warns when one enumerated type is implicitly converted to another.

    drivers/infiniband/hw/mlx4/mad.c:1811:41: warning: implicit conversion
    from enumeration type 'enum mlx4_ib_qp_flags' to different enumeration
    type 'enum ib_qp_create_flags' [-Wenum-conversion]
    qp_init_attr.init_attr.create_flags = MLX4_IB_SRIOV_TUNNEL_QP;
    ~ ^~~~~~~~~~~~~~~~~~~~~~~

    drivers/infiniband/hw/mlx4/mad.c:1819:41: warning: implicit conversion
    from enumeration type 'enum mlx4_ib_qp_flags' to different enumeration
    type 'enum ib_qp_create_flags' [-Wenum-conversion]
    qp_init_attr.init_attr.create_flags = MLX4_IB_SRIOV_SQP;
    ~ ^~~~~~~~~~~~~~~~~

    The type mlx4_ib_qp_flags explicitly provides supplemental values to the
    type ib_qp_create_flags. Make that clear to Clang by changing the
    create_flags type to u32.

    Reported-by: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/rdma/ib_verbs.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
    index f3d475024d376..54e4d1fd21f8f 100644
    --- a/include/rdma/ib_verbs.h
    +++ b/include/rdma/ib_verbs.h
    @@ -1147,7 +1147,7 @@ struct ib_qp_init_attr {
    struct ib_qp_cap cap;
    enum ib_sig_type sq_sig_type;
    enum ib_qp_type qp_type;
    - enum ib_qp_create_flags create_flags;
    + u32 create_flags;

    /*
    * Only needed for special QP types, or when using the RW API.
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-22 12:00    [W:2.596 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site