lkml.org 
[lkml]   [2019]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 06/13] exfat: add exfat entry operations
    From
    Date

    > +++ b/fs/exfat/fatent.c

    > +int exfat_free_cluster(struct inode *inode, struct exfat_chain *p_chain)
    > +{

    > +out:
    > + sbi->used_clusters -= num_clusters;

    Can a label like “decrement_counter” be more helpful?



    > +int exfat_mirror_bh(struct super_block *sb, sector_t sec,
    > + struct buffer_head *bh)
    > +{

    > + if (!c_bh) {
    > + err = -ENOMEM;
    > + goto out;
    > + }

    Can it be nicer to return directly?


    > +out:
    > + return err;
    > +}

    Would you like to omit such a label for this function implementation?

    Regards,
    Markus

    \
     
     \ /
      Last update: 2019-11-21 15:12    [W:4.045 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site