Messages in this thread | | | Subject | Re: [PATCH v4 06/13] exfat: add exfat entry operations | From | Markus Elfring <> | Date | Thu, 21 Nov 2019 15:10:10 +0100 |
| |
… > +++ b/fs/exfat/fatent.c … > +int exfat_free_cluster(struct inode *inode, struct exfat_chain *p_chain) > +{ … > +out: > + sbi->used_clusters -= num_clusters;
Can a label like “decrement_counter” be more helpful?
… > +int exfat_mirror_bh(struct super_block *sb, sector_t sec, > + struct buffer_head *bh) > +{ … > + if (!c_bh) { > + err = -ENOMEM; > + goto out; > + }
Can it be nicer to return directly?
… > +out: > + return err; > +}
Would you like to omit such a label for this function implementation?
Regards, Markus
| |