Messages in this thread | | | Subject | RE: [PATCH v2 1/5] genirq: introduce irq domain tra nslate onecell | Date | Thu, 21 Nov 2019 09:20:18 +0000 | From | Marc Zyngier <> |
| |
On 2019-11-21 08:55, Yash Shah wrote:
[...]
>> > > + * bindings where the cell values map directly to the hwirq >> number. >> > > + */ >> > > +int irq_domain_translate_onecell(struct irq_domain *d, >> > > + struct irq_fwspec *fwspec, >> > > + unsigned long *out_hwirq, >> > > + unsigned int *out_type) >> > > +{ >> > > + if (WARN_ON(fwspec->param_count < 1)) >> > > + return -EINVAL; >> > > + *out_hwirq = fwspec->param[0]; >> > > + *out_type = IRQ_TYPE_NONE; >> > > + return 0; >> > > +} >> > > +EXPORT_SYMBOL_GPL(irq_domain_translate_onecell); >> > > + >> > > +/** >> > > * irq_domain_translate_twocell() - Generic translate for >> direct >> > > two cell >> > > * bindings >> > > * >> > >> > Can you please also update (potentially in a separate patch) the >> > potential users of this? I mentioned the nvic driver last time... >> > >> >> Ok, I will separate out this patch from the patchset and send it >> individually >> along with potential users of it. >> Thanks for your comments > > I am sorry, I think I misunderstood you. > You want me to send a new separate patch in which the potential users > will be updated to this new function. > Hope I got it right?
Just add, as part of this series, a patch that updates the one or two drivers that could make use of this. It doesn't need to be in a separate patch set (which would cause dependency issues).
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |