Messages in this thread | | | Date | Thu, 21 Nov 2019 18:04:55 -0800 | From | Eric Biggers <> | Subject | Re: [PATCH v6 1/8] crypto: x86/glue_helper: Regularize function prototypes |
| |
On Thu, Nov 21, 2019 at 05:03:27PM -0800, Kees Cook wrote: > The crypto glue performed function prototype casting to make indirect > calls to assembly routines. Instead of performing casts at the call > sites (which trips Control Flow Integrity prototype checking), switch > each prototype to a common standard set of arguments which allows the > incremental removal of the existing macros. In order to keep pointer > math unchanged, internal casting between u128 pointers and u8 pointers > is added. > > Co-developed-by: João Moreira <joao.moreira@intel.com> > Signed-off-by: Kees Cook <keescook@chromium.org>
Co-developers need their own Signed-off-by. checkpatch.pl warns about this.
- Eric
| |