Messages in this thread | | | From | Pavel Tatashin <> | Date | Thu, 21 Nov 2019 19:39:22 -0500 | Subject | Re: [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd_call |
| |
> > That may be, but be very careful that you only use them in ARMv7-only > > code. Using them elsewhere is unsafe as the domain register is used > > for other purposes, and merely blatting over it (as your > > uaccess_enable and uaccess_disable functions do) is unsafe. > > In fact, I'll turn that into a bit more than a suggestion. I'll make > it a NAK on adding them to 32-bit ARM. >
That's fine, and I also did not want to change ARM 32-bit. But, do you have a suggestion how differentiate between arm64 and arm in include/xen/arm/hypercall.h without ugly ifdefs?
Thank you, Pasha
| |