lkml.org 
[lkml]   [2019]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 56/83] USB: storage: ums-realtek: Whitelist auto-delink support
    3.16.78-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kai-Heng Feng <kai.heng.feng@canonical.com>

    commit 1902a01e2bcc3abd7c9a18dc05e78c7ab4a53c54 upstream.

    Auto-delink requires writing special registers to ums-realtek devices.
    Unconditionally enable auto-delink may break newer devices.

    So only enable auto-delink by default for the original three IDs,
    0x0138, 0x0158 and 0x0159.

    Realtek is working on a patch to properly support auto-delink for other
    IDs.

    BugLink: https://bugs.launchpad.net/bugs/1838886
    Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Link: https://lore.kernel.org/r/20190827173450.13572-2-kai.heng.feng@canonical.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/storage/realtek_cr.c | 13 ++++++++-----
    1 file changed, 8 insertions(+), 5 deletions(-)

    --- a/drivers/usb/storage/realtek_cr.c
    +++ b/drivers/usb/storage/realtek_cr.c
    @@ -1001,12 +1001,15 @@ static int init_realtek_cr(struct us_dat
    goto INIT_FAIL;
    }

    - if (CHECK_FW_VER(chip, 0x5888) || CHECK_FW_VER(chip, 0x5889) ||
    - CHECK_FW_VER(chip, 0x5901))
    - SET_AUTO_DELINK(chip);
    - if (STATUS_LEN(chip) == 16) {
    - if (SUPPORT_AUTO_DELINK(chip))
    + if (CHECK_PID(chip, 0x0138) || CHECK_PID(chip, 0x0158) ||
    + CHECK_PID(chip, 0x0159)) {
    + if (CHECK_FW_VER(chip, 0x5888) || CHECK_FW_VER(chip, 0x5889) ||
    + CHECK_FW_VER(chip, 0x5901))
    SET_AUTO_DELINK(chip);
    + if (STATUS_LEN(chip) == 16) {
    + if (SUPPORT_AUTO_DELINK(chip))
    + SET_AUTO_DELINK(chip);
    + }
    }
    #ifdef CONFIG_REALTEK_AUTOPM
    if (ss_en)
    \
     
     \ /
      Last update: 2019-11-20 16:42    [W:3.106 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site