Messages in this thread | | | From | Avri Altman <> | Subject | RE: [PATCH v4 5/5] scsi: ufs: Do not free irq in suspend | Date | Wed, 20 Nov 2019 15:36:59 +0000 |
| |
> > If PM QoS is enabled and we set request type to PM_QOS_REQ_AFFINE_IRQ > then freeing up the irq makes the free_irq() print out warning with call stack. > We don't really need to free up irq during suspend, disabling it during suspend > and reenabling it during resume should be good enough. > > Signed-off-by: Can Guo <cang@codeaurora.org> Your approach seems reasonable, However I failed to locate in the kernel PM_QOS_REQ_AFFINE_IRQ, Just in codeaurora.
Is the WARN_ON in free_irq still applies?
Thanks, Avri
| |