Messages in this thread | | | From | Heiko Stübner <> | Subject | Re: [PATCH 2/5] arm64: dts: rockchip: Add VMARC RK3399Pro SOM initial support | Date | Wed, 20 Nov 2019 14:28:50 +0100 |
| |
Hi Jagan,
looks good in general, just some small things below:
Am Mittwoch, 20. November 2019, 12:39:20 CET schrieb Jagan Teki: > VMARC RK3399Pro SOM is a standard SMARC SOM design with > Rockchip RK3399Pro SoC, which is designed by Vamrs. > > Specification: > - Rockchip RK3399Pro > - PMIC: RK809-3 > - SD slot, 16GiB eMMC > - 2xUSB-2.0, 1xUSB3.0 > - USB-C for power supply > - Ethernet, PCIe > - HDMI, MIPI-DSI/CSI, eDP > > Add initial support for VMARC RK3399Pro SOM, this would use > with associated carrier board. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > .../dts/rockchip/rk3399pro-vmarc-som.dtsi | 339 ++++++++++++++++++ > 1 file changed, 339 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi b/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi > new file mode 100644 > index 000000000000..ddf6ebc9fbe3 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi > @@ -0,0 +1,339 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2019 Fuzhou Rockchip Electronics Co., Ltd > + * Copyright (c) 2019 Vamrs Limited > + * Copyright (c) 2019 Amarula Solutions(India) > + */ > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/pinctrl/rockchip.h> > +#include <dt-bindings/pwm/pwm.h> > + > +/ { > + compatible = "vamrs,rk3399pro-vmarc-som", "rockchip,rk3399pro"; > + > + clkin_gmac: external-gmac-clock { > + compatible = "fixed-clock"; > + clock-frequency = <125000000>; > + clock-output-names = "clkin_gmac"; > + #clock-cells = <0>; > + }; > + > + vcc5v0_sys: vcc5v0-sys-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vcc5v0_sys"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>;
Is vcc5v0_sys really the topmost regulator getting the outside power-supply?
> + }; > + > + vcc_lan: vcc3v3-phy-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_lan";
vcc_lan / vcc_phy is mostly coming from the vendor bsp in some way and will be named differently in schematics ... also it should be connected to the regulator tree.
[...]
> +&tsadc { > + status = "okay"; > + > + /* tshut mode 0:CRU 1:GPIO */
I think we can live without the additional comments for properties :-)
> + rockchip,hw-tshut-mode = <1>; > + /* tshut polarity 0:LOW 1:HIGH */ > + rockchip,hw-tshut-polarity = <1>; > +};
Heiko
| |