Messages in this thread | | | Date | Wed, 20 Nov 2019 13:41:01 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 2/4] x86/traps: Print non-canonical address on #GP |
| |
On Wed, Nov 20, 2019 at 01:25:30PM +0100, Jann Horn wrote: > On Wed, Nov 20, 2019 at 12:24 PM Borislav Petkov <bp@alien8.de> wrote: > > On Wed, Nov 20, 2019 at 12:18:59PM +0100, Ingo Molnar wrote: > > > How was this maximum string length of '90' derived? In what way will > > > that have to change if someone changes the message? > > > > That was me counting the string length in a dirty patch in a previous > > thread. We probably should say why we decided for a certain length and > > maybe have a define for it. > > Do you think something like this would be better? > > char desc[sizeof(GPFSTR) + 50 + 2*sizeof(unsigned long) + 1] = GPFSTR;
Yap, and the 50 is a sufficiently large number so that all possible string combinations in this case can fit in the resulting string array.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |