lkml.org 
[lkml]   [2019]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 10/13] exfat: add nls operations
From
Date
>> …
>>> +++ b/fs/exfat/nls.c
>> …
>>> +static int exfat_load_upcase_table(struct super_block *sb,
>>> + sector_t sector, unsigned long long num_sectors,
>>> + unsigned int utbl_checksum)
>>> +{
>> …
>>> +error:
>>> + if (bh)
>>> + brelse(bh);

>> Can the label “release_bh” be more helpful?

> I checked not only review point but also your review points in
> other patches, I will fix them on v4.


Another software design alternative would be to use a jump target
like “free_table” instead at this source code place, wouldn't it?

Regards,
Markus

\
 
 \ /
  Last update: 2019-11-20 13:37    [W:0.107 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site