Messages in this thread | | | Subject | Re: [PATCH v3 10/13] exfat: add nls operations | From | Markus Elfring <> | Date | Wed, 20 Nov 2019 13:36:05 +0100 |
| |
>> … >>> +++ b/fs/exfat/nls.c >> … >>> +static int exfat_load_upcase_table(struct super_block *sb, >>> + sector_t sector, unsigned long long num_sectors, >>> + unsigned int utbl_checksum) >>> +{ >> … >>> +error: >>> + if (bh) >>> + brelse(bh); … >> Can the label “release_bh” be more helpful? … > I checked not only review point but also your review points in > other patches, I will fix them on v4. …
Another software design alternative would be to use a jump target like “free_table” instead at this source code place, wouldn't it?
Regards, Markus
| |