Messages in this thread | | | Date | Tue, 19 Nov 2019 19:18:03 -0800 (PST) | Subject | Re: [PATCH] mdio_bus: Fix init if CONFIG_RESET_CONTROLLER=n | From | David Miller <> |
| |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Tue, 19 Nov 2019 19:55:53 +0100
> Hi Florian, > > On Tue, Nov 19, 2019 at 7:05 PM Florian Fainelli <f.fainelli@gmail.com> wrote: >> On 11/19/19 3:25 AM, Geert Uytterhoeven wrote: >> > Commit 1d4639567d970de0 ("mdio_bus: Fix PTR_ERR applied after >> > initialization to constant") accidentally changed a check from -ENOTSUPP >> > to -ENOSYS, causing failures if reset controller support is not enabled. >> > E.g. on r7s72100/rskrza1: >> > >> > sh-eth e8203000.ethernet: MDIO init failed: -524 >> > sh-eth: probe of e8203000.ethernet failed with error -524 >> > >> > Fixes: 1d4639567d970de0 ("mdio_bus: Fix PTR_ERR applied after initialization to constant") >> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> This has been fixed in the "net" tree with: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=075e238d12c21c8bde700d21fb48be7a3aa80194 > > Ah, hadn't seen that one. > > However, that one (a) keeps the unneeded check for -ENOSYS, and (b) > carries a wrong Fixes tag.
Linus took Geert's fix so I reverted the one in 'net' and cherry picked Geert's fix from Linus's tree.
Just FYI...
| |