Messages in this thread | | | Date | Tue, 19 Nov 2019 22:36:24 +0000 | From | Qais Yousef <> | Subject | Re: [PATCH 12/12] cpu: Hide cpu_up/down |
| |
On 11/19/19 23:25, Thomas Gleixner wrote: > On Wed, 30 Oct 2019, Qais Yousef wrote: > > -int cpu_down(unsigned int cpu) > > +static int cpu_down(unsigned int cpu) > > { > > return do_cpu_down(cpu, CPUHP_OFFLINE); > > } > > -EXPORT_SYMBOL(cpu_down); > > The exports should be gone already at this point, right?
Yes. The only in-kernel user was the torture test.
> > +/* > > + * This function is meant to be used by device core cpu subsystem. > > + * > > + * Other subsystems should use device_offline(get_cpu_device(cpu)) instead. > > + */ > > Can you please use proper kernel-doc function documentation?
Will do.
Thanks
-- Qais Yousef
| |